Do not use root logger#2082
Open
lachesis wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2082 +/- ##
==========================================
+ Coverage 96.94% 96.96% +0.01%
==========================================
Files 156 156
Lines 7535 7535
==========================================
+ Hits 7305 7306 +1
+ Misses 230 229 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I'm happy to rebase this forward if anyone is interested in taking the changes... |
felixdittrich92
added
type: enhancement
felixdittrich92
requested changes
Jul 8, 2026
felixdittrich92
left a comment
felixdittrich92
left a comment
Collaborator
There was a problem hiding this comment.
Hi @lachesis 👋
Thanks for the PR yes please rebase your PR.
And one thing please use the logger init at module level
For example:
import logging
import xyz
logger = logging.getLogger(__name__)
...code
logger.warning("No model URL or Path provided, using default initialization.")
...code
logger.info("XYZ")Please verify that each module which uses logging. init it's logger on top of the module like in the example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling logging.info() at module level with no logger configured triggers logging.basicConfig() automatically (Python's "last resort" behavior) — which creates a StreamHandler on root with WARNING level.
This poisons logging config for anything downstream of this.
Instead, create a logger scoped to doctr package.
Example repro script:
Output:
Expected:
Replaces #2076